linux-kernel - Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201811281350.8dQyqZu0%fengguang.wu@intel.com>
Date:   Wed, 28 Nov 2018 13:19:13 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Florian Eckert <fe@....tdt.de>
Cc:     kbuild-all@...org, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, dvhart@...radead.org,
        andy@...radead.org, Eckert.Florian@...glemail.com,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, Florian Eckert <fe@....tdt.de>
Subject: Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

Hi Florian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on gpio/for-next]
[also build test ERROR on v4.20-rc4 next-20181127]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Florian-Eckert/Add-device-driver-for-APU2-APU3-GPIOs/20181128-045043
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/gpio/gpio-apu.c:13:0:
>> include/linux/module.h:213:1: error: expected ',' or ';' before 'extern'
    extern typeof(name) __mod_##type##__##name##_device_table  \
    ^
>> drivers/gpio/gpio-apu.c:163:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
    MODULE_DEVICE_TABLE(dmi, apu2_gpio_dmi_table);
    ^~~~~~~~~~~~~~~~~~~

vim +213 include/linux/module.h

^1da177e Linus Torvalds    2005-04-16  209  
cff26a51 Rusty Russell     2014-02-03  210  #ifdef MODULE
cff26a51 Rusty Russell     2014-02-03  211  /* Creates an alias so file2alias.c can find device table. */
^1da177e Linus Torvalds    2005-04-16  212  #define MODULE_DEVICE_TABLE(type, name)					\
0bf8bf50 Matthias Kaehlcke 2017-07-24 @213  extern typeof(name) __mod_##type##__##name##_device_table		\
cff26a51 Rusty Russell     2014-02-03  214    __attribute__ ((unused, alias(__stringify(name))))
cff26a51 Rusty Russell     2014-02-03  215  #else  /* !MODULE */
cff26a51 Rusty Russell     2014-02-03  216  #define MODULE_DEVICE_TABLE(type, name)
cff26a51 Rusty Russell     2014-02-03  217  #endif
^1da177e Linus Torvalds    2005-04-16  218  

:::::: The code at line 213 was first introduced by commit
:::::: 0bf8bf50eddc7511b52461bae798cbfaa0157a34 module: Remove const attribute from alias for MODULE_DEVICE_TABLE

:::::: TO: Matthias Kaehlcke <mka@...omium.org>
:::::: CC: Jessica Yu <jeyu@...nel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (66034 bytes)