linux-kernel - Re: [PATCH] sis5513: fix potential use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181128070524.GB30936@infradead.org>
Date:   Tue, 27 Nov 2018 23:05:24 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Pan Bian <bianpan2016@....com>
Cc:     "David S. Miller" <davem@...emloft.net>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sis5513: fix potential use after free

On Wed, Nov 28, 2018 at 08:55:26AM +0800, Pan Bian wrote:
> The function sis_find_family drops lpc_bridge reference via pci_dev_put,
> however, after that, field lpc_bridge->revision is read. This may result
> in a use after free bug. The patch moves the put operation after the
> condition check.
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>