linux-kernel - Re: [PATCH v2 1/3] reset: imx7: Add plubming to support multiple IP variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Nov 2018 16:07:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        p.zabel@...gutronix.de, Fabio Estevam <fabio.estevam@....com>,
        cphealy@...il.com, l.stach@...gutronix.de,
        Leonard Crestez <leonard.crestez@....com>,
        "A.s. Dong" <aisheng.dong@....com>,
        Richard Zhu <hongxing.zhu@....com>,
        Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        linux-imx@....com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] reset: imx7: Add plubming to support multiple IP
 variants

Hi Andrey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pza/reset/next]
[also build test WARNING on v4.20-rc4 next-20181127]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andrey-Smirnov/Reset-controller-support-for-i-MX8MQ/20181128-143936
base:   git://git.pengutronix.de/git/pza/linux reset/next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   drivers//reset/reset-imx7.c: In function 'imx7_reset_probe':
>> drivers//reset/reset-imx7.c:160:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     imx7src->variant = of_device_get_match_data(dev);
                      ^

vim +/const +160 drivers//reset/reset-imx7.c

   149	
   150	static int imx7_reset_probe(struct platform_device *pdev)
   151	{
   152		struct imx7_src *imx7src;
   153		struct device *dev = &pdev->dev;
   154		struct regmap_config config = { .name = "src" };
   155	
   156		imx7src = devm_kzalloc(dev, sizeof(*imx7src), GFP_KERNEL);
   157		if (!imx7src)
   158			return -ENOMEM;
   159	
 > 160		imx7src->variant = of_device_get_match_data(dev);
   161		imx7src->regmap = syscon_node_to_regmap(dev->of_node);
   162		if (IS_ERR(imx7src->regmap)) {
   163			dev_err(dev, "Unable to get imx7-src regmap");
   164			return PTR_ERR(imx7src->regmap);
   165		}
   166		regmap_attach_dev(dev, imx7src->regmap, &config);
   167	
   168		imx7src->rcdev.owner     = THIS_MODULE;
   169		imx7src->rcdev.nr_resets = imx7src->variant->signals_num;
   170		imx7src->rcdev.ops       = &imx7_reset_ops;
   171		imx7src->rcdev.of_node   = dev->of_node;
   172	
   173		return devm_reset_controller_register(dev, &imx7src->rcdev);
   174	}
   175	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (55736 bytes)