linux-kernel - Re: [PATCH v2 3/3] perf report: Display average IPC and IPC coverage per symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e44fd7a5-07f0-5760-d1cc-a689d8d06cfa@linux.intel.com>
Date:   Wed, 28 Nov 2018 09:45:59 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, kan.liang@...el.com,
        yao.jin@...el.com
Subject: Re: [PATCH v2 3/3] perf report: Display average IPC and IPC coverage
 per symbol



On 11/28/2018 2:33 AM, Andi Kleen wrote:
> On Tue, Nov 27, 2018 at 08:09:48PM +0800, Jin Yao wrote:
>> Support displaying the average IPC and IPC coverage for symbol
>> in perf report TUI browser. We create a new sort-key 'ipc' for
>> that.
> 
> Another thing that would be nice would be to automatically enable
> these columns perf report when -b was enabled in the perf.data.
> We can't check for timed LBR being supported without
> looking into samples, but at least can check for -b.
> 
> Otherwise a lot of people won't realize it's supported.
> 
> It would show always 0.0 when timed LBR is not supported,
> but that might be ok. Perhaps make both columns empty
> in this case instead of 0.0.
> 
> 
> -Andi
> 

Hi Andi,

Yes, I agree, people will not realize a new option 'ipc' is created.

So I will enable 2 columns ("IPC" and "IPC columns") even when timed LBR 
is not supported. Just show empty or '-' in these columns.

Thanks
Jin Yao