linux-kernel - Re: [PATCH 1/2] kernel/kcov.c: mark funcs in __sanitizer_cov_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181128090507.41791fe7@gandalf.local.home>
Date:   Wed, 28 Nov 2018 09:05:07 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     akpm@...ux-foundation.org, dvyukov@...gle.com, mingo@...hat.com,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/2] kernel/kcov.c: mark funcs in
 __sanitizer_cov_trace_pc as notrace

On Wed, 28 Nov 2018 09:12:39 +0100
Anders Roxell <anders.roxell@...aro.org> wrote:

> Since __sanitizer_cov_trace_pc is marked as notrace, function calls in
> __sanitizer_cov_trace_pc shouldn't be traced either. The function
> ftrace_graph_caller() gets called for each function that isn't marked
> 'notrace', like canonicalize_ip(). This is the call trace from a run:
> 
> [  139.644550]  ftrace_graph_caller+0x1c/0x24
> [  139.648352]  canonicalize_ip+0x18/0x28
> [  139.652313]  __sanitizer_cov_trace_pc+0x14/0x58
> [  139.656184]  sched_clock+0x34/0x1e8
> [  139.659759]  trace_clock_local+0x40/0x88
> [  139.663722]  ftrace_push_return_trace+0x8c/0x1f0
> [  139.667767]  prepare_ftrace_return+0xa8/0x100
> [  139.671709]  ftrace_graph_caller+0x1c/0x24
> 
> Rework so that the functions check_kcov_mode and canonicalize_ip that is
> callef from __sanitizer_cov_trace_pc also is marked as notrace.
> 
> Co-developed-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signen-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve