linux-kernel - Re: [PATCH] mtd: spi-nor: parse SFDP 4-byte Address Instruction Table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1052dff-e1a9-2d3f-b921-661c72e0e137@microchip.com>
Date:   Wed, 28 Nov 2018 14:17:12 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <boris.brezillon@...tlin.com>
CC:     <marek.vasut@...il.com>, <dwmw2@...radead.org>,
        <computersforpeace@...il.com>, <richard@....at>,
        <Cyrille.Pitchen@...rochip.com>, <linux-mtd@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: parse SFDP 4-byte Address Instruction Table



On 11/28/2018 09:57 AM, Boris Brezillon wrote:
> On Tue, 20 Nov 2018 11:55:21 +0000
> <Tudor.Ambarus@...rochip.com> wrote:
> 
>> +
>> +	/*
>> +	 * We set nor->addr_width here to skip spi_nor_set_4byte_opcodes()
>> +	 * later because this latest function implements a legacy quirk for
>> +	 * the erase size of Spansion memory. However this quirk is no longer
>> +	 * needed with new SFDP compliant memories.
>> +	 */
>> +	nor->addr_width = 4;
>> +	nor->flags |= SPI_NOR_4B_OPCODES;
> 
> You mean SNOR_F_4B_OPCODES (the one introduced here [1]), because
> SPI_NOR_4B_OPCODES should only be used for flash_info->flags and might
> soon conflict with another SNOR_F_ flag?
> 

yes, you're right.

> [1]http://patchwork.ozlabs.org/patch/991476/
> 

Can you apply your patch? Will submit a new version afterwards.

Thanks,
ta