linux-kernel - Re: [PATCH v4 2/2] ptrace: add PTRACE_GET_SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181128142930.GF30395@redhat.com>
Date:   Wed, 28 Nov 2018 15:29:30 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     "Dmitry V. Levin" <ldv@...linux.org>
Cc:     Andy Lutomirski <luto@...nel.org>,
        Elvira Khabirova <lineprinter@...linux.org>,
        Eugene Syromyatnikov <esyr@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Jann Horn <jannh@...gle.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
        strace-devel@...ts.strace.io
Subject: Re: [PATCH v4 2/2] ptrace: add PTRACE_GET_SYSCALL_INFO request

On 11/28, Oleg Nesterov wrote:
>
> On 11/28, Dmitry V. Levin wrote:
> >
> > +static unsigned long
> > +ptrace_get_syscall_info_entry(struct task_struct *child,
> > +			      struct ptrace_syscall_info *info)
> > +{
> > +	struct pt_regs *regs = task_pt_regs(child);
> > +	unsigned long args[ARRAY_SIZE(info->entry.args)];
> > +	int i;
> > +
> > +	info->op = PTRACE_SYSCALL_INFO_ENTRY;
> > +	info->arch = syscall_get_arch(child);
> > +	info->entry.nr = syscall_get_nr(child, regs);
> > +	info->entry.instruction_pointer = instruction_pointer(regs);
> > +	info->entry.stack_pointer = user_stack_pointer(regs);
> > +	info->entry.frame_pointer = frame_pointer(regs);
> > +	syscall_get_arguments(child, regs, 0, ARRAY_SIZE(args), args);
> > +	for (i = 0; i < ARRAY_SIZE(args); i++)
> > +		info->entry.args[i] = args[i];
>
> I must have missed something,

Yes ;) I didn't look at info->entry.args, it is __u64[6].

> but why do we need the temporary args[],
> syscall_get_arguments(..., info->entry.args) should equally work?
> 
> Oleg.