linux-kernel - Re: [PATCH v2] mtd: change len type from signed to unsigned type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMy0x0=H0pwHN09Bp_eKkHFHwbURFLt3MKJvBNC51TyqiZJyGA@mail.gmail.com>
Date:   Wed, 28 Nov 2018 23:51:06 +0900
From:   Huijin Park <bbanghj.park@...il.com>
To:     miquel.raynal@...tlin.com
Cc:     huijin.park@...sung.com, boris.brezillon@...tlin.com,
        Marek Vašut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: change len type from signed to unsigned type

Hi Miquèl,

On Thu, Nov 15, 2018 at 6:29 PM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
>
> Hi Huijin,
>
> Huijin Park <huijin.park@...sung.com> wrote on Thu, 15 Nov 2018
> 00:07:10 -0500:
>
> > From: "huijin.park" <huijin.park@...sung.com>
> >
> > This patch casts the "len" parameter to an unsigned int.
> > The callers of erase_write() pass the "len" parameter as unsigned int.
>
> Indeed. Perhaps it is worth backporting this patch to a stable releases?
>

It doesn't need backporting.
Because this patch is for enforcing code correctness.

> >
> > Signed-off-by: huijin.park <huijin.park@...sung.com>
> > ---
> >  drivers/mtd/mtdblock.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
> > index a5b1933..b2d5ed1 100644
> > --- a/drivers/mtd/mtdblock.c
> > +++ b/drivers/mtd/mtdblock.c
> > @@ -56,7 +56,7 @@ struct mtdblk_dev {
> >   */
> >
> >  static int erase_write (struct mtd_info *mtd, unsigned long pos,
> > -                     int len, const char *buf)
> > +                     unsigned int len, const char *buf)
> >  {
> >       struct erase_info erase;
> >       size_t retlen;
>
> Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
>
>
> Thanks,
> Miquèl

Thanks,
Huijin