linux-kernel - Re: [PATCH 1/1] ASoC: pcm3168a: Don't disable pcm3168a when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181128162211.GL6828@sirena.org.uk>
Date:   Wed, 28 Nov 2018 16:22:11 +0000
From:   Mark Brown <broonie@...nel.org>
To:     jiada_wang@...tor.com
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        kuninori.morimoto.gx@...esas.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ASoC: pcm3168a: Don't disable pcm3168a when
 CONFIG_PM defined

On Wed, Nov 28, 2018 at 09:26:12PM +0900, jiada_wang@...tor.com wrote:
> From: Jiada Wang <jiada_wang@...tor.com>
> 
> pcm3168 codec support runtime_[resume|suspend], whenever it
> is not active, it enters suspend mode, and it's clock and regulators
> will be disabled. so there is no need to disable them again in
> remove callback.  Otherwise we got following kernel warnings,
> when unload pcm3168a driver
> 
> [  222.257514] unbalanced disables for amp-en-regulator
> [  222.262526] ------------[ cut here ]------------
> [  222.267158] WARNING: CPU: 0 PID: 2423 at drivers/regulator/core.c:2264 _regulator_disable+0x28/0x108
> [  222.276291] Modules linked in:
> [  222.279343]  snd_soc_pcm3168a_i2c(-)

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative then it's
usually better to pull out the relevant sections.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)