linux-kernel - Re: [PATCH v5 2/2] platform: Add reset button device for PC Engines APU boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Nov 2018 01:06:55 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Florian Eckert <fe@....tdt.de>
Cc:     kbuild-all@...org, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, dvhart@...radead.org,
        andy@...radead.org, Eckert.Florian@...glemail.com,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, Florian Eckert <fe@....tdt.de>
Subject: Re: [PATCH v5 2/2] platform: Add reset button device for PC Engines
 APU boards

Hi Florian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on gpio/for-next]
[also build test ERROR on v4.20-rc4 next-20181128]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Florian-Eckert/Add-device-driver-for-APU2-APU3-GPIOs/20181128-045043
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/gpio/gpio-apu.c:163:1: error: Expected ; at end of declaration
>> drivers/gpio/gpio-apu.c:163:1: error: got extern
   In file included from drivers/gpio/gpio-apu.c:13:0:
   include/linux/module.h:213:1: error: expected ',' or ';' before 'extern'
    extern typeof(name) __mod_##type##__##name##_device_table  \
    ^
   drivers/gpio/gpio-apu.c:163:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
    MODULE_DEVICE_TABLE(dmi, apu2_gpio_dmi_table);
    ^~~~~~~~~~~~~~~~~~~

vim +163 drivers/gpio/gpio-apu.c

4c30b3d4 Florian Eckert 2018-11-27  135  
4c30b3d4 Florian Eckert 2018-11-27  136  static const struct dmi_system_id apu2_gpio_dmi_table[] __initconst = {
4c30b3d4 Florian Eckert 2018-11-27  137  	/* PC Engines APU2 with "Legacy" bios < 4.0.8 */
4c30b3d4 Florian Eckert 2018-11-27  138  	{
4c30b3d4 Florian Eckert 2018-11-27  139  		.ident = "apu2",
4c30b3d4 Florian Eckert 2018-11-27  140  		.matches = {
4c30b3d4 Florian Eckert 2018-11-27  141  			DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
4c30b3d4 Florian Eckert 2018-11-27  142  			DMI_MATCH(DMI_BOARD_NAME, "APU2")
4c30b3d4 Florian Eckert 2018-11-27  143  		}
4c30b3d4 Florian Eckert 2018-11-27  144  	},
4c30b3d4 Florian Eckert 2018-11-27  145  	/* PC Engines APU2 with "Legacy" bios >= 4.0.8 */
4c30b3d4 Florian Eckert 2018-11-27  146  	{
4c30b3d4 Florian Eckert 2018-11-27  147  		.ident = "apu2",
4c30b3d4 Florian Eckert 2018-11-27  148  		.matches = {
4c30b3d4 Florian Eckert 2018-11-27  149  			DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
4c30b3d4 Florian Eckert 2018-11-27  150  			DMI_MATCH(DMI_BOARD_NAME, "apu2")
4c30b3d4 Florian Eckert 2018-11-27  151  		}
4c30b3d4 Florian Eckert 2018-11-27  152  	},
4c30b3d4 Florian Eckert 2018-11-27  153  	/* PC Engines APU2 with "Mainline" bios */
4c30b3d4 Florian Eckert 2018-11-27  154  	{
4c30b3d4 Florian Eckert 2018-11-27  155  		.ident = "apu2",
4c30b3d4 Florian Eckert 2018-11-27  156  		.matches = {
4c30b3d4 Florian Eckert 2018-11-27  157  			DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
4c30b3d4 Florian Eckert 2018-11-27  158  			DMI_MATCH(DMI_BOARD_NAME, "PC Engines apu2")
4c30b3d4 Florian Eckert 2018-11-27  159  		}
4c30b3d4 Florian Eckert 2018-11-27  160  	},
4c30b3d4 Florian Eckert 2018-11-27  161  	{}
4c30b3d4 Florian Eckert 2018-11-27  162  }
4c30b3d4 Florian Eckert 2018-11-27 @163  MODULE_DEVICE_TABLE(dmi, apu2_gpio_dmi_table);
4c30b3d4 Florian Eckert 2018-11-27  164  

:::::: The code at line 163 was first introduced by commit
:::::: 4c30b3d47204299cdb436562e2099c4a72427db7 gpio: Add driver for PC Engines APU boards

:::::: TO: Florian Eckert <fe@....tdt.de>
:::::: CC: 0day robot <lkp@...el.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (66638 bytes)