linux-kernel - [tip:x86/boot] x86/boot: Add missing va

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-69be4efeb959147ff86f22e35aea9526f9b86715@git.kernel.org>
Date:   Wed, 28 Nov 2018 11:15:54 -0800
From:   tip-bot for Mattias Jacobsson <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     bp@...e.de, mingo@...nel.org, 2pi@....nu,
        linux-kernel@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de,
        hpa@...or.com
Subject: [tip:x86/boot] x86/boot: Add missing va_end() to die()

Commit-ID:  69be4efeb959147ff86f22e35aea9526f9b86715
Gitweb:     https://git.kernel.org/tip/69be4efeb959147ff86f22e35aea9526f9b86715
Author:     Mattias Jacobsson <2pi@....nu>
AuthorDate: Wed, 28 Nov 2018 17:16:07 +0100
Committer:  Borislav Petkov <bp@...e.de>
CommitDate: Wed, 28 Nov 2018 20:06:07 +0100

x86/boot: Add missing va_end() to die()

Each call to va_start() must have a corresponding call to va_end()
before the end of the function. Add the missing va_end().

Found with Coccinelle.

Signed-off-by: Mattias Jacobsson <2pi@....nu>
Signed-off-by: Borislav Petkov <bp@...e.de>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Link: https://lkml.kernel.org/r/20181128161607.10973-1-2pi@mok.nu
---
 arch/x86/boot/tools/build.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
index bf0e82400358..a93d44e58f9c 100644
--- a/arch/x86/boot/tools/build.c
+++ b/arch/x86/boot/tools/build.c
@@ -132,6 +132,7 @@ static void die(const char * str, ...)
 	va_list args;
 	va_start(args, str);
 	vfprintf(stderr, str, args);
+	va_end(args);
 	fputc('\n', stderr);
 	exit(1);
 }