linux-kernel - Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181128.215241.702406654469517539.davem@davemloft.net>
Date:   Wed, 28 Nov 2018 21:52:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     dmitry.bezrukov@...antia.com, igor.russkikh@...antia.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in
 aqc111_suspend

From: Nathan Chancellor <natechancellor@...il.com>
Date: Wed, 28 Nov 2018 22:18:09 -0700

> Clang warns:
> 
> drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> initialization of subobject [-Wmissing-braces]
>                 struct aqc111_wol_cfg wol_cfg = { 0 };
>                                                   ^
>                                                   {}
> 1 warning generated.
> 
> Add another set of braces to initialize the char subobjects as well.
> 
> Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

This will in turn make some versions of gcc warn.

Please just memset() this object, thanks.