linux-kernel - Re: [PATCH] PCI: pciehp: Report degraded links via link bandwidth notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Nov 2018 21:30:12 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Alex_Gagniuc@...lteam.com
Cc:     mr.nuke.me@...il.com, bhelgaas@...gle.com, Austin.Bolen@...l.com,
        keith.busch@...el.com, Shyam.Iyer@...l.com, lukas@...ner.de,
        okaya@...eaurora.org, rafael.j.wysocki@...el.com,
        poza@...eaurora.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Report degraded links via link bandwidth
 notification

On Thu, Nov 29, 2018 at 07:00:58PM +0000, Alex_Gagniuc@...lteam.com wrote:
> >> +	if (link_status & PCI_EXP_LNKSTA_LBMS) {
> >> +		if (pdev->subordinate && pdev->subordinate->self)
> >> +			endpoint = pdev->subordinate->self;
> > 
> > Hmm, I thought pdev->subordinate->self == pdev, no?
> 
> That makes no sense, but I think you're right. I'm trying to get to the 
> other end of the PCIe link. Is there a simple way to do that? (other 
> than convoluted logic that all leads to the same mistake)

AFAIK you should be able to find the other end by looking at the
pdev->subordinate->devices list. Not sure if there is a simpler way,
though.