linux-kernel - Re: [PATCH] pstore: Fix bool initialization/comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKpXpcQ4tM+m3Fwk+3CqH-pWF5xme2zgq=ojS=GMzqjQw@mail.gmail.com>
Date:   Thu, 29 Nov 2018 15:21:50 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Thomas Meyer <thomas@...3r.de>
Cc:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH] pstore: Fix bool initialization/comparison

On Sat, Oct 7, 2017 at 7:24 AM Thomas Meyer <thomas@...3r.de> wrote:
> Bool initializations should use true and false. Bool tests don't need
> comparisons.
>
> Signed-off-by: Thomas Meyer <thomas@...3r.de>

I totally missed this email (now over a year ago!)

However, since it's still correct and applies, I've taken it for -next
now. :) Thanks!

-Kees

> ---
>
> diff -u -p a/fs/pstore/ftrace.c b/fs/pstore/ftrace.c
> --- a/fs/pstore/ftrace.c
> +++ b/fs/pstore/ftrace.c
> @@ -148,7 +148,7 @@ void pstore_unregister_ftrace(void)
>         mutex_lock(&pstore_ftrace_lock);
>         if (pstore_ftrace_enabled) {
>                 unregister_ftrace_function(&pstore_ftrace_ops);
> -               pstore_ftrace_enabled = 0;
> +               pstore_ftrace_enabled = false;
>         }
>         mutex_unlock(&pstore_ftrace_lock);
>


-- 
Kees Cook