linux-kernel - Re: [PATCH] drm: msm: Check cmd_db_read_aux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGvWekbG6WsB_7Ux9FAdcci8xrHUZLcCd0rw05CNLNqQRQ@mail.gmail.com>
Date:   Thu, 29 Nov 2018 18:24:41 -0500
From:   Rob Clark <robdclark@...il.com>
To:     Andy Gross <andy.gross@...aro.org>
Cc:     Stephen Boyd <swboyd@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>, lkp@...el.com,
        Jordan Crouse <jcrouse@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Evan Green <evgreen@...omium.org>,
        Sean Paul <seanpaul@...omium.org>
Subject: Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

On Thu, Nov 29, 2018 at 5:36 PM Andy Gross <andy.gross@...aro.org> wrote:
>
> On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote:
> > We need to check the call to cmd_db_read_aux_data() for the error case,
> > so that we don't continue and use potentially uninitialized values for
> > 'pri_count' and 'sec_count'. Otherwise, we get the following compiler
> > warnings:
> >
> >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function 'a6xx_gmu_rpmh_arc_votes_init.isra.12':
> >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count' is used uninitialized in this function [-Wuninitialized]
> >      pri_count >>= 1;
> >                ^~~
> >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count' may be used uninitialized in this function
> > [-Wmaybe-uninitialized]
> >      sec_count >>= 1;
> >                ^~~
> >
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Reported-by: kbuild test robot <lkp@...el.com>
> > Cc: Jordan Crouse <jcrouse@...eaurora.org>
> > Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> > Cc: Evan Green <evgreen@...omium.org>
> > Cc: Jordan Crouse <jcrouse@...eaurora.org>
> > Cc: Rob Clark <robdclark@...il.com>
> > Fixes: ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()")
> > Signed-off-by: Stephen Boyd <swboyd@...omium.org>
>
> Thanks for the patch.  Queueing this up.
>

from talking to agross on IRC, seems like this becomes an issue w/
other patches he has queued up for 4.21, and I don't think this should
conflict w/ other stuff I have, so

Acked-by: Rob Clark <robdclark@...il.com>

for Andy picking up this one

BR,
-R

>
> Andy