linux-kernel - Re: [Xen-devel] [PATCH 0/2] Move RSDP address out of setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22e0ae54-9d7e-bea5-c8b8-5eac2c9174c1@knorrie.org>
Date:   Thu, 29 Nov 2018 02:05:24 +0100
From:   Hans van Kranenburg <hans@...rrie.org>
To:     Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
        xen-devel@...ts.xenproject.org, x86@...nel.org
Cc:     sstabellini@...nel.org, daniel.kiper@...cle.com, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com, boris.ostrovsky@...cle.com,
        tglx@...utronix.de
Subject: Re: [Xen-devel] [PATCH 0/2] Move RSDP address out of setup_header

Hi,

On 11/20/18 8:25 AM, Juergen Gross wrote:
> Resend with Daniel's mailo address corrected
> 
> Instead of passing the RSDP address for Xen PVH guests from grub2 to
> the kernel in setup_header move it into the non-legacy part of the
> boot_params structure.
> 
> This patch series should be applied rather sooner than later in order
> to avoid shipping linux 4.20 with a corky boot protocol.
> 
> Juergen Gross (2):
>   x86/boot: revert commit ae7e1238e68f2a (Add ACPI RSDP address to
>     setup_header)
>   x86/acpi, x86/boot: Take RSDP address from boot params if available
> 
>  Documentation/x86/boot.txt            | 32 +-------------------------------
>  arch/x86/boot/header.S                |  6 +-----
>  arch/x86/include/asm/x86_init.h       |  2 --
>  arch/x86/include/uapi/asm/bootparam.h |  7 ++-----
>  arch/x86/kernel/acpi/boot.c           |  2 +-
>  arch/x86/kernel/head32.c              |  1 -
>  arch/x86/kernel/head64.c              |  2 --
>  arch/x86/kernel/setup.c               | 17 -----------------
>  8 files changed, 5 insertions(+), 64 deletions(-)

FWIW, I can confirm that I can boot a Xen domU in PVH mode with the
following four patches added on top of Linux 4.19.5 (applied in this
order), in combination with grub master branch with patchset v5 for grub
on top:

Date:   Wed Oct 10 08:14:55 2018 +0200
x86/boot: Add ACPI RSDP address to setup_header

Date:   Wed Oct 10 08:14:56 2018 +0200
x86/acpi, x86/boot: Take RSDP address for boot params if available

Date:   Tue Nov 20 08:25:28 2018 +0100
x86/boot: revert commit ae7e1238e68f2a (Add ACPI RSDP address to
setup_header)

Date:   Tue Nov 20 08:25:29 2018 +0100
x86/acpi, x86/boot: Take RSDP address from boot params if available

[    0.205884] Booting paravirtualized kernel on Xen PVH

Thanks,
Hans