[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <38bdc5f7-63b5-7276-921f-258ee876c45b@redhat.com>
Date: Thu, 29 Nov 2018 11:12:07 +0100
From: David Hildenbrand <david@...hat.com>
To: Michal Hocko <mhocko@...nel.org>,
Nikolay Borisov <nborisov@...e.com>
Cc: linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
David Sterba <dsterba@...e.com>,
"Yan, Zheng" <zyan@...hat.com>, Sage Weil <sage@...hat.com>,
Ilya Dryomov <idryomov@...il.com>,
Steve French <sfrench@...ba.org>,
Theodore Ts'o <tytso@....edu>,
Andreas Dilger <adilger.kernel@...ger.ca>,
Mark Fasheh <mark@...heh.com>,
Joel Becker <jlbec@...lplan.org>,
Mike Marshall <hubcap@...ibond.com>,
Martin Brandenburg <martin@...ibond.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Mike Rapoport <rppt@...ux.vnet.ibm.com>,
Matthew Wilcox <willy@...radead.org>,
Randy Dunlap <rdunlap@...radead.org>,
YueHaibing <yuehaibing@...wei.com>,
Shakeel Butt <shakeelb@...gle.com>,
Dan Williams <dan.j.williams@...el.com>,
linux-afs@...ts.infradead.org, linux-btrfs@...r.kernel.org,
ceph-devel@...r.kernel.org, linux-cifs@...r.kernel.org,
samba-technical@...ts.samba.org, linux-ext4@...r.kernel.org,
ocfs2-devel@....oracle.com, devel@...ts.orangefs.org,
linux-mm@...ck.org
Subject: Re: [PATCH 2/2] fs: Don't open-code lru_to_page
On 29.11.18 09:18, Michal Hocko wrote:
> On Thu 29-11-18 09:52:57, Nikolay Borisov wrote:
>> There are a bunch of filesystems which essentially open-code lru_to_page
>> helper. Change them to using the helper. No functional changes.
>
> I would just squash the two into a single patch. It makes the first one
> more obvious. Or is there any reason to have them separate?
>
>> Signed-off-by: Nikolay Borisov <nborisov@...e.com>
>
> Acked-by: Michal Hocko <mhocko@...e.com>
mm_inline.h is 99.9% about lru and there is barely anything about lru in
mm.h. However this simple macro seems to differ from the other inlined
functions.
So to the squashed patch
Reviewed-by: David Hildenbrand <david@...hat.com>
--
Thanks,
David / dhildenb
Powered by blists - more mailing lists