linux-kernel - Re: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <293c53a6-3313-359a-c5d0-2e2fa453494a@arm.com>
Date:   Thu, 29 Nov 2018 10:21:53 +0000
From:   Dave Rodgman <dave.rodgman@....com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        nd <nd@....com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Matt Sealey <Matt.Sealey@....com>,
        "nitingupta910@...il.com" <nitingupta910@...il.com>,
        "rpurdie@...nedhand.com" <rpurdie@...nedhand.com>,
        "markus@...rhumer.com" <markus@...rhumer.com>,
        "minchan@...nel.org" <minchan@...nel.org>,
        "sonnyrao@...gle.com" <sonnyrao@...gle.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: Re: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo



On 29/11/2018 4:43 am, Sergey Senozhatsky wrote:
> On (11/27/18 16:19), Dave Rodgman wrote:
>>   Documentation/lzo.txt         |  12 ++-
>>   crypto/Makefile               |   2 +-
>>   crypto/lzo-rle.c              | 175 ++++++++++++++++++++++++++++++++++++++++++
>>   crypto/tcrypt.c               |   4 +-
>>   drivers/block/zram/zcomp.c    |   1 +
>>   drivers/block/zram/zram_drv.c |   2 +-
>>   include/linux/lzo.h           |   4 +
>>   lib/lzo/lzo1x_compress.c      |  42 +++++++---
>>   lib/lzo/lzodefs.h             |   3 +-
>>   9 files changed, 227 insertions(+), 18 deletions(-)
>>   create mode 100644 crypto/lzo-rle.c
> 
> [..]
> 
>> +static struct crypto_alg alg = {
>> +	.cra_name		= "lzo-rle",
>> +	.cra_flags		= CRYPTO_ALG_TYPE_COMPRESS,
>> +	.cra_ctxsize		= sizeof(struct lzorle_ctx),
>> +	.cra_module		= THIS_MODULE,
>> +	.cra_init		= lzorle_init,
>> +	.cra_exit		= lzorle_exit,
>> +	.cra_u			= { .compress = {
>> +	.coa_compress		= lzorle_compress,
>> +	.coa_decompress		= lzorle_decompress } }
>> +};
> 
> A nitpick:
>    indentation for .compress assignment is a bit confusing, maybe.

Agreed - I've copied this directly from crypto/lzo.c though, so I 
retained the same style. Cleanup could be a separate patch.

> [..]
>> +++ b/drivers/block/zram/zcomp.c
>> @@ -20,6 +20,7 @@
>>   
>>   static const char * const backends[] = {
>>   	"lzo",
>> +	"lzo-rle",
>>   #if IS_ENABLED(CONFIG_CRYPTO_LZ4)
>>   	"lz4",
>>   #endif
> 
> [..]
> 
>> +++ b/drivers/block/zram/zram_drv.c
>> @@ -41,7 +41,7 @@ static DEFINE_IDR(zram_index_idr);
>>   static DEFINE_MUTEX(zram_index_mutex);
>>   
>>   static int zram_major;
>> -static const char *default_compressor = "lzo";
>> +static const char *default_compressor = "lzo-rle";
> 
> OK, so it's not just "separate lzo-rle", it's also "switch zram to
> a new compression algorithm by default". I'd say that usually I'd
> expect this to be separate patches.

Yes, fair point. akpm has picked this up now though, so probably a bit 
late to break it out into a separate patch?

Dave