linux-kernel - Re: [PATCH] printk: Make printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181129102919.vfswav3ybemt3ute@pathway.suse.cz>
Date:   Thu, 29 Nov 2018 12:47:25 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: Make printk_emit() local function.

On Sat 2018-11-24 13:10:25, Tetsuo Handa wrote:
> Well, moving "__printf(3, 4) __cold" to before
> "int devkmsg_emit(int facility, int level, const char *fmt, ...) {"
> seems to be working. I did not know...
> 
> >From 86fff21e5fef6d3f7970cf5c07a54a907e582b52 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Date: Sat, 24 Nov 2018 13:05:25 +0900
> Subject: [PATCH v2] printk: Make printk_emit() local function.
> 
> printk_emit() is called from only devkmsg_write() in the same file.
> Save object size by making it a local function.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

JFYI, I have pushed it into printk.git, for-4.21 branch.

Best Regards,
Petr