linux-kernel - Re: [PATCH] ASoC: stm32: sai: Fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181129115545.GD10570@sirena.org.uk>
Date:   Thu, 29 Nov 2018 11:55:45 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Wen Yang <wen.yang99@....com.cn>
Cc:     olivier.moysan@...com, arnaud.pouliquen@...com, tiwai@...e.com,
        mcoquelin.stm32@...il.com, linux-kernel@...r.kernel.org,
        zhong.weidong@....com.cn, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Julia Lawall <julia.lawall@...6.fr>,
        Wen Yang <yellowriver2010@...mail.com>,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH] ASoC: stm32: sai: Fix unsigned comparison with less than
 zero

On Thu, Nov 29, 2018 at 10:06:11AM +0800, Wen Yang wrote:
> The return from the call to stm32_sai_get_clk_div can be a negative error
> code however this is being assigned to an unsigned variable 'div'
> hence the check is always false. Fix this by making 'div' an
> int.

This doesn't apply against current code, please check and resend.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)