linux-kernel - Re: [PATCH 00/27] locking/lockdep: Add support for dynamic keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Nov 2018 13:31:40 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     mingo@...hat.com, tj@...nel.org, johannes.berg@...el.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/27] locking/lockdep: Add support for dynamic keys

On Wed, Nov 28, 2018 at 03:42:58PM -0800, Bart Van Assche wrote:
> Hi Ingo and Peter,
> 
> A known shortcoming of the current lockdep implementation is that it requires
> lock keys to be allocated statically and that this key sharing can cause false
> positive deadlock reports. This patch series adds support for dynamic keys in
> the lockdep code. I'm not claiming that this patch series is perfect. However,
> the code in this patch series survives nontrivial tests so I think it's worth
> a look. Two unrelated changes in this patch series are:
> - Improve the lockdep tests.
> - Complain if no name has been assigned to a lock object.

Looks very good mostly, and it improves the lives of people that like
modules too.

Thanks for doing all that.