linux-kernel - Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181129133051.GA11799@kroah.com>
Date:   Thu, 29 Nov 2018 14:30:51 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     Paolo Pisati <p.pisati@...il.com>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        netdev@...r.kernel.org, stable@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL &
 RX_ADDRH regs are always up to date

On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote:
> On Thu, Nov 08, 2018 at 12:01:27PM +0100, Paolo Pisati wrote:
> > On Wed, Nov 07, 2018 at 07:17:51PM -0500, Sasha Levin wrote:
> > > So why not just take 760db29bdc completely? It looks safer than taking a
> > > partial backport, and will make applying future patches easier.
> > > 
> > > I tried to do it and it doesn't look like there are any dependencies
> > > that would cause an issue.
> > 
> > Somehow i was convinced it didn't build on 4.4.x... can you pick it up?
> > 
> > commit 760db29bdc97b73ff60b091315ad787b1deb5cf5
> > Author: Phil Elwell <phil@...pberrypi.org>
> > Date:   Thu Apr 19 17:59:38 2018 +0100
> > 
> >    lan78xx: Read MAC address from DT if present
> > 
> >    There is a standard mechanism for locating and using a MAC address from
> >    the Device Tree. Use this facility in the lan78xx driver to support
> >    applications without programmed EEPROM or OTP. At the same time,
> >    regularise the handling of the different address sources.
> > 
> >    Signed-off-by: Phil Elwell <phil@...pberrypi.org>
> >    Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> Can you confirm it actually works on 4.4?

It does not build on 4.4, so I'm dropping it :(

greg k-h