linux-kernel - Re: [PATCH] sysctl: clean up nr_pdflush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <867FB7CF-C7CC-454F-8845-5026FC3D5BEA@oracle.com>
Date:   Thu, 29 Nov 2018 07:09:56 -0700
From:   William Kucharski <william.kucharski@...cle.com>
To:     Rafael Aquini <aquini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        davem@...emloft.net, virgile@...eis.fr, linux-mm@...ck.org
Subject: Re: [PATCH] sysctl: clean up nr_pdflush_threads leftover



> On Nov 28, 2018, at 8:24 AM, Rafael Aquini <aquini@...hat.com> wrote:
> 
> nr_pdflush_threads has been long deprecated and
> removed, but a remnant of its glorious past is
> still around in CTL_VM names enum. This patch
> is a minor clean-up to that case.
> 
> Signed-off-by: Rafael Aquini <aquini@...hat.com>
> ---
> include/uapi/linux/sysctl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
> index d71013fffaf6..dad5a8f93343 100644
> --- a/include/uapi/linux/sysctl.h
> +++ b/include/uapi/linux/sysctl.h
> @@ -174,7 +174,7 @@ enum
> 	VM_DIRTY_RATIO=12,	/* dirty_ratio */
> 	VM_DIRTY_WB_CS=13,	/* dirty_writeback_centisecs */
> 	VM_DIRTY_EXPIRE_CS=14,	/* dirty_expire_centisecs */
> -	VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
> +	VM_UNUSED15=15,		/* was: int nr_pdflush_threads */
> 	VM_OVERCOMMIT_RATIO=16, /* percent of RAM to allow overcommit in */
> 	VM_PAGEBUF=17,		/* struct: Control pagebuf parameters */
> 	VM_HUGETLB_PAGES=18,	/* int: Number of available Huge Pages */
> -- 
> 2.17.2
> 

Please reword the comment to add a colon after the word "int" to match earlier
comments in the enum:

+	VM_UNUSED15=15,		/* was: int: nr_pdflush_threads */

Also, as long as you're changing this file, please fix the typo earlier in the
same enum:

-	VM_UNUSED2=2,		/* was; int: Linear or sqrt() swapout for hogs */
+	VM_UNUSED2=2,		/* was: int: Linear or sqrt() swapout for hogs */


Reviewed-by: William Kucharski <william.kucharski@...cle.com>