linux-kernel - Re: [PATCH] dmaengine: at_hdmac: fix memory leak in at_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181129142054.GH3175@vkoul-mobl.Dlink>
Date:   Thu, 29 Nov 2018 19:50:55 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Richard Genoud <richard.genoud@...il.com>
Cc:     Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Mario Forner <m.forner@...energy.com>,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] dmaengine: at_hdmac: fix memory leak in at_dma_xlate()

On 27-11-18, 17:06, Richard Genoud wrote:
> The leak was found when opening/closing a serial port a great number of
> time, increasing kmalloc-32 in slabinfo.
> 
> Each time the port was opened, dma_request_slave_channel() was called.
> Then, in at_dma_xlate(), atslave was allocated with devm_kzalloc() and
> never freed. (Well, it was free at module unload, but that's not what we
> want).
> So, here, kzalloc is more suited for the job since it has to be freed in
> atc_free_chan_resources().

Applied, thanks

-- 
~Vinod