linux-kernel - Re: [PATCH RFC 03/15] drm/nouveau: replace **** with a hug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+ToGPEaxYxuzB__SM77J_8596u8Q+wa4uqfDn+LbwmL_NsOhA@mail.gmail.com>
Date:   Fri, 30 Nov 2018 20:03:37 -0200
From:   Diego Viola <diego.viola@...il.com>
To:     jarkko.sakkinen@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, bskeggs@...hat.com, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org
Subject: Re: [PATCH RFC 03/15] drm/nouveau: replace **** with a hug

On Fri, Nov 30, 2018 at 7:26 PM Jarkko Sakkinen
<jarkko.sakkinen@...ux.intel.com> wrote:
>
> On Fri, Nov 30, 2018 at 06:13:50PM -0200, Diego Viola wrote:
> > On Fri, Nov 30, 2018 at 5:30 PM Jarkko Sakkinen
> > <jarkko.sakkinen@...ux.intel.com> wrote:
> > >
> > > In order to comply with the CoC, replace **** with a hug.
> > >
> > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > ---
> > >  drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c        | 2 +-
> > >  drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> > > index 9cc10e438b3d..55a0060881ea 100644
> > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> > > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> > > @@ -446,7 +446,7 @@ init_ram_restrict(struct nvbios_init *init)
> > >  {
> > >         /* This appears to be the behaviour of the VBIOS parser, and *is*
> > >          * important to cache the NV_PEXTDEV_BOOT0 on later chipsets to
> > > -        * avoid fucking up the memory controller (somehow) by reading it
> > > +        * avoid hugging up the memory controller (somehow) by reading it
> > >          * on every INIT_RAM_RESTRICT_ZM_GROUP opcode.
> > >          *
> > >          * Preserving the non-caching behaviour on earlier chipsets just
> > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc
> > > index 3737bd27f74e..ee364c71cc2e 100644
> > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc
> > > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc
> > > @@ -46,7 +46,7 @@
> > >  #define NV_PPWR_INTR_EN_SET_SUBINTR                                  0x00000800
> > >  #define NV_PPWR_INTR_EN_SET_WATCHDOG                                 0x00000002
> > >  #define NV_PPWR_INTR_EN_CLR                                              0x0014
> > > -#define NV_PPWR_INTR_EN_CLR_MASK                    /* fuck i hate envyas */ -1
> > > +#define NV_PPWR_INTR_EN_CLR_MASK                    /* hug i hate envyas */ -1
> >
> > Can you also capitalize the "i" please?
>
> Yeah, maybe I just change it as "/* I hate envyas */"?
>
> /Jarkko

Yes, that looks better.

Thanks,
Diego