linux-kernel - RE: [RFC PATCH v2 07/15] usb:cdns3: Adds Device mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Nov 2018 06:29:31 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     PETER CHEN <peter.chen@....com>, Felipe Balbi <balbi@...nel.org>,
        Roger Quadros <rogerq@...com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alan Douglas <adouglas@...ence.com>,
        "jbergsagel@...com" <jbergsagel@...com>,
        "nsekhar@...com" <nsekhar@...com>, "nm@...com" <nm@...com>,
        Suresh Punnoose <sureshp@...ence.com>,
        Pawel Jez <pjez@...ence.com>, Rahul Kumar <kurahul@...ence.com>
Subject: RE: [RFC PATCH v2 07/15] usb:cdns3: Adds Device mode support -
 initialization.

Hi,

>> Roger Quadros <rogerq@...com> writes:
>> >> +static void cdns3_gadget_config(struct cdns3_device *priv_dev) {
>> >> +	struct cdns3_usb_regs __iomem *regs = priv_dev->regs;
>> >> +
>> >> +	cdns3_ep0_config(priv_dev);
>> >> +
>> >> +	/* enable interrupts for endpoint 0 (in and out) */
>> >> +	writel(EP_IEN_EP_OUT0 | EP_IEN_EP_IN0, &regs->ep_ien);
>> >> +
>> >> +	/* enable generic interrupt*/
>> >> +	writel(USB_IEN_INIT, &regs->usb_ien);
>> >> +	writel(USB_CONF_CLK2OFFDS | USB_CONF_L1DS, &regs->usb_conf);
>> >> +	writel(USB_CONF_DMULT, &regs->usb_conf);
>> >> +	writel(USB_CONF_DEVEN, &regs->usb_conf);
>> >
>> > If you are enabling interrupts in this patch you should handle them in the ISR.
>>
>> Frankly, I don't understand why this is a series. It's a single driver and splitting it into
>> a series just makes it more difficult to review, actually.
>>
>> Sure, a single patch will be large, but there's no way to have a functional driver until
>> all patches are applied, anyway.
>>
>
>Yes, I agree with Felipe. Pawel, you could remove the "RFC" prefix, and send the whole
>one as one patch. I will test it at my hardware.

Ok, I will prepare such single patch.  
Peter I know that you have little different platform. 
Probably you should made some additional changes for your platform. 

I assume that core.c should be common file. 
Probably we should add also some platform specific file. 

Thanks.  

Pawel.