linux-kernel - Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154356242517.88331.8496814814468751012@swboyd.mtv.corp.google.com>
Date:   Thu, 29 Nov 2018 23:20:25 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     bcousson@...libre.com, letux-kernel@...nphoenux.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, mturquette@...libre.com,
        paul@...an.com, t-kristo@...com, tony@...mide.com
Subject: Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Quoting Andreas Kemnade (2018-11-29 22:15:34)
> Hi Stephen,
> 
> On Thu, 29 Nov 2018 16:25:05 -0800
> Stephen Boyd <sboyd@...nel.org> wrote:
> 
> > Quoting Andreas Kemnade (2018-11-10 12:31:14)
> > > Code might use autoidle api with clocks not being omap2 clocks,
> > > so check if clock type is not basic
> > > 
> > > Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> > > ---
> > > New in v2
> > > ---
> > >  drivers/clk/ti/autoidle.c | 12 ++++++++++--
> > >  1 file changed, 10 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/clk/ti/autoidle.c b/drivers/clk/ti/autoidle.c
> > > index 161f67850393..5bdae5552d38 100644
> > > --- a/drivers/clk/ti/autoidle.c
> > > +++ b/drivers/clk/ti/autoidle.c
> > > @@ -54,8 +54,12 @@ static DEFINE_SPINLOCK(autoidle_spinlock);
> > >  int omap2_clk_deny_idle(struct clk *clk)
> > >  {
> > >         struct clk_hw_omap *c;
> > > +       struct clk_hw *hw = __clk_get_hw(clk);
> > >  
> > > -       c = to_clk_hw_omap(__clk_get_hw(clk));
> > > +       if (clk_hw_get_flags(hw) & CLK_IS_BASIC)  
> > 
> > Please try to avoid using CLK_IS_BASIC if at all possible. Can you?
> > Maybe add some flag in clk_hw_omap() instead?
> > 
> hmm, Tero suggested that.
> But to check flags in clk_hw_omap I first need to know that there is a
> clk_hw_omap behind clk_hw. And for that I either need to check flags in
> clk_hw or do more changes in the omap_hwmod code.

Can you do it? The omap code is the only user of CLK_IS_BASIC. All the
other users are marking clks with this but there is no reason to do so.
I'll go make another pass over the tree and nuke those ones from orbit.