[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <154356849500.88331.9932899465368459791@swboyd.mtv.corp.google.com>
Date: Fri, 30 Nov 2018 01:01:35 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: linux-arm-msm@...r.kernel.org, Taniya Das <tdas@...eaurora.org>,
Douglas Anderson <dianders@...omium.org>,
devicetree@...r.kernel.org,
Michael Turquette <mturquette@...libre.com>,
linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>, linux-clk@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: Require #reset-cells in sdm845-videocc
Quoting Douglas Anderson (2018-11-27 11:24:43)
> The #reset-cells was listed as optional in the bindings for
> qcom,sdm845-videocc. There's no reason for it to be optional. As per
> Stephen [1]:
>
> > We should update the binding to make it a required property. It
> > doesn't make any sense why that property would be optional given
> > that the hardware either has support for resets or it doesn't.
>
> sdm845 support is still in its infancy so we shouldn't be affecting
> any real device trees by modifying the bindings here.
>
> [1] https://lkml.kernel.org/r/154330186815.88331.12720647562079303842@swboyd.mtv.corp.google.com
>
> Fixes: 84b66b211603 ("dt-bindings: clock: Introduce QCOM Video clock bindings")
> Suggested-by: Stephen Boyd <sboyd@...nel.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
Applied to clk-next
Powered by blists - more mailing lists