linux-kernel - Re: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b504430-fb4b-340b-66c2-1300c816cc3a@arm.com>
Date:   Fri, 30 Nov 2018 10:45:08 +0000
From:   Dave Rodgman <dave.rodgman@....com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     nd <nd@....com>
Subject: Re: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo

On 29/11/2018 4:43 am, Sergey Senozhatsky wrote:
> On (11/27/18 16:19), Dave Rodgman wrote:> 
>> +static struct crypto_alg alg = {
>> +	.cra_name		= "lzo-rle",
>> +	.cra_flags		= CRYPTO_ALG_TYPE_COMPRESS,
>> +	.cra_ctxsize		= sizeof(struct lzorle_ctx),
>> +	.cra_module		= THIS_MODULE,
>> +	.cra_init		= lzorle_init,
>> +	.cra_exit		= lzorle_exit,
>> +	.cra_u			= { .compress = {
>> +	.coa_compress		= lzorle_compress,
>> +	.coa_decompress		= lzorle_decompress } }
>> +};
> 
> A nitpick:
>    indentation for .compress assignment is a bit confusing, maybe.

Looking a bit more closely, these structs are formatted fairly 
inconsistently in the crypto directory. So, lzo-rle is consistent with 
what lzo does... but various other files do it differently.

I'm happy to submit a whitespace cleanup patch if people would like, and 
get everything in that directory consistent (i.e. adopt a style similar 
to the example below)?

static struct scomp_alg scomp = {
         .alloc_ctx              = lzorle_alloc_ctx,
         .free_ctx               = lzorle_free_ctx,
         .compress               = lzorle_scompress,
         .decompress             = lzorle_sdecompress,
         .base                   = {
                 .cra_name               = "lzo-rle",
                 .cra_driver_name        = "lzo-rle-scomp",
                 .cra_module             = THIS_MODULE,
         }
};

Dave