linux-kernel - Re: [PATCH] HID: input: support Microsoft wireless radio control hotkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201811301805.c7R8QkBM%fengguang.wu@intel.com>
Date:   Fri, 30 Nov 2018 18:46:05 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Chris Chiu <chiu@...lessm.com>
Cc:     kbuild-all@...org, jikos@...nel.org, benjamin.tissoires@...hat.com,
        rydberg@...math.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux@...lessm.com,
        Chris Chiu <chiu@...lessm.com>
Subject: Re: [PATCH] HID: input: support Microsoft wireless radio control
 hotkey

Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc4 next-20181130]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Chiu/HID-input-support-Microsoft-wireless-radio-control-hotkey/20181130-150723
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=m68k 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/hid/hid-input.c:32:0:
   drivers/hid/hid-input.c: In function 'hidinput_connect':
>> include/linux/hid.h:839:99: error: expected expression before '||' token
    #define IS_INPUT_APPLICATION(a) (((a >= 0x00010000) && (a <= 0x00010008)) || (a == 0x00010080) || || (a == 0x0001000c) || (a == 0x000c0001) || ((a >= 0x000d0002) && (a <= 0x000d0006)))
                                                                                                      ^
>> drivers/hid/hid-input.c:1737:9: note: in expansion of macro 'IS_INPUT_APPLICATION'
        if (IS_INPUT_APPLICATION(col->usage))
            ^~~~~~~~~~~~~~~~~~~~
--
   In file included from drivers//hid/hid-input.c:32:0:
   drivers//hid/hid-input.c: In function 'hidinput_connect':
>> include/linux/hid.h:839:99: error: expected expression before '||' token
    #define IS_INPUT_APPLICATION(a) (((a >= 0x00010000) && (a <= 0x00010008)) || (a == 0x00010080) || || (a == 0x0001000c) || (a == 0x000c0001) || ((a >= 0x000d0002) && (a <= 0x000d0006)))
                                                                                                      ^
   drivers//hid/hid-input.c:1737:9: note: in expansion of macro 'IS_INPUT_APPLICATION'
        if (IS_INPUT_APPLICATION(col->usage))
            ^~~~~~~~~~~~~~~~~~~~

vim +839 include/linux/hid.h

   836	
   837	/* Applications from HID Usage Tables 4/8/99 Version 1.1 */
   838	/* We ignore a few input applications that are not widely used */
 > 839	#define IS_INPUT_APPLICATION(a) (((a >= 0x00010000) && (a <= 0x00010008)) || (a == 0x00010080) || || (a == 0x0001000c) || (a == 0x000c0001) || ((a >= 0x000d0002) && (a <= 0x000d0006)))
   840	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (12152 bytes)