linux-kernel - Re: [PATCH] drm: msm: Check cmd_db_read_aux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Nov 2018 20:34:47 -0600
From:   Andy Gross <andy.gross@...aro.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Stephen Boyd <swboyd@...omium.org>, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        kbuild test robot <lkp@...el.com>,
        Jordan Crouse <jcrouse@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Evan Green <evgreen@...omium.org>,
        Rob Clark <robdclark@...il.com>
Subject: Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

On Fri, Nov 30, 2018 at 01:12:01PM +1100, Stephen Rothwell wrote:
> Hi Andy,
> 
> On Thu, 29 Nov 2018 16:42:34 -0600 Andy Gross <andy.gross@...aro.org> wrote:
> >
> > On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote:
> > > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote:  
> > > > We need to check the call to cmd_db_read_aux_data() for the error case,
> > > > so that we don't continue and use potentially uninitialized values for
> > > > 'pri_count' and 'sec_count'. Otherwise, we get the following compiler
> > > > warnings:
> > > > 
> > > >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function 'a6xx_gmu_rpmh_arc_votes_init.isra.12':
> > > >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count' is used uninitialized in this function [-Wuninitialized]
> > > >      pri_count >>= 1;
> > > >                ^~~
> > > >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count' may be used uninitialized in this function
> > > > [-Wmaybe-uninitialized]
> > > >      sec_count >>= 1;
> > > >                ^~~
> > > > 
> > > > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > > > Reported-by: kbuild test robot <lkp@...el.com>
> > > > Cc: Jordan Crouse <jcrouse@...eaurora.org>
> > > > Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> > > > Cc: Evan Green <evgreen@...omium.org>
> > > > Cc: Jordan Crouse <jcrouse@...eaurora.org>
> > > > Cc: Rob Clark <robdclark@...il.com>
> > > > Fixes: ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()")
> > > > Signed-off-by: Stephen Boyd <swboyd@...omium.org>  
> > 
> > On second thought, this needs to go through drm tree.
> 
> Why?  The commit that introduces the warnings is only in the qcom

Sorry, I wasn't thinking it through earlier.  Yes, due to the two patches in our
tree changing the API, this needs to go through my tree.  I asked Rob to ack
it so I could take it in.  He did that and now it's been added to my pull and
also pushed to -next.

Sorry for the confusion on my part.

Andy