linux-kernel - Re: [PATCH v2] fs: fix lost error code in dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c98c7576-53d6-cfd6-8b16-3edbf4c01d50@kernel.dk>
Date:   Fri, 30 Nov 2018 08:15:20 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Christoph Hellwig <hch@....de>, Maximilian Heyne <mheyne@...zon.de>
Cc:     Torsten Mehlan <tomeh@...zon.de>, Uwe Dannowski <uwed@...zon.de>,
        Amit Shah <aams@...zon.de>,
        David Woodhouse <dwmw@...zon.co.uk>, stable@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs: fix lost error code in dio_complete

On 11/30/18 3:46 AM, Christoph Hellwig wrote:
> Al, Jens,
> 
> can someone pick this up, please?
> 
> On Fri, Nov 30, 2018 at 10:02:22AM +0100, Maximilian Heyne wrote:
>> On 11/8/18 7:58 PM, Maximilian Heyne wrote:
>>> commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the
>>> generic_write_sync prototype") reworked callers of generic_write_sync(),
>>> and ended up dropping the error return for the directio path. Prior to
>>> that commit, in dio_complete(), an error would be bubbled up the stack,
>>> but after that commit, errors passed on to dio_complete were eaten up.
>>>
>>> This was reported on the list earlier, and a fix was proposed in
>>> https://lore.kernel.org/lkml/20160921141539.GA17898@infradead.org/, but
>>> never followed up with.  We recently hit this bug in our testing where
>>> fencing io errors, which were previously erroring out with EIO, were
>>> being returned as success operations after this commit.
>> I just wanted to follow up on this. Has anyone picked up this patch?

I'll pick it up.

-- 
Jens Axboe