linux-kernel - RE: [PATCH V2] ASoC: max98373: Added max98373

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB3131F092601136FF5E626A96E7D30@DM6PR11MB3131.namprd11.prod.outlook.com>
Date:   Fri, 30 Nov 2018 03:17:57 +0000
From:   Ryan Lee <RyanS.Lee@...imintegrated.com>
To:     Mark Brown <broonie@...nel.org>,
        Grant Grundler <grundler@...omium.org>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Benson Leung <bleung@...omium.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "ryan.lee.maxim@...il.com" <ryan.lee.maxim@...il.com>
Subject: RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp
 reset

>-----Original Message-----
>From: Mark Brown <broonie@...nel.org>
>Sent: Thursday, November 29, 2018 3:26 AM
>To: Grant Grundler <grundler@...omium.org>
>Cc: Ryan Lee <RyanS.Lee@...imintegrated.com>; Liam Girdwood
><lgirdwood@...il.com>; perex@...ex.cz; tiwai@...e.com; Kuninori
>Morimoto <kuninori.morimoto.gx@...esas.com>; Benson Leung
><bleung@...omium.org>; alsa-devel@...a-project.org; LKML <linux-
>kernel@...r.kernel.org>; ryan.lee.maxim@...il.com
>Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable
>amp reset
>
>On Wed, Nov 28, 2018 at 05:55:48PM -0800, Grant Grundler wrote:
>> On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee
><RyanS.Lee@...imintegrated.com> wrote:
>
>> > >Not seeing a changelog here like I asked for :(
>
>> > Actually I added changelog as below. Do you mean this is not sufficient?
>
>> The text is probably sufficient but not in a format that Mark can
>> directly apply.
>> Please take a quick look at Documentation/process/submitting-patches.rst.
>
>> Mark wants the "commit message" to be before the '---' line. So move
>> the "Changes:" text up to become the commit message and drop the
>> "Changes" line. That should explain why this commit is needed and
>> include the S-o-B line.
>
>Right.  If you compare what's in git and what you're sending with other
>commits and mails and make sure everything looks similar you're probably on
>the right track.
I'm sorry for the mistake. Let me fix it.