linux-kernel - trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181201143144.GC31631@amd>
Date:   Sat, 1 Dec 2018 15:31:44 +0100
From:   Pavel Machek <pavel@....cz>
To:     jacek.anaszewski@...il.com, linux-leds@...r.kernel.org
Cc:     kernel list <linux-kernel@...r.kernel.org>, kvalo@...eaurora.org,
        davem@...emloft.net, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Subject: trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c

Hi!

While grepping something else, I came across LED trigger that is named
just "tx".

That's a bit too generic afaict?

+++ b/drivers/net/wireless/atmel/at76c50x-usb.c
@@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device
*udev, u8 *buf, u32 size,
 static int tx_activity;
  static void at76_ledtrig_tx_timerfunc(struct timer_list *unused);
   static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc);
   -DEFINE_LED_TRIGGER(ledtrig_tx);
   +DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic
   name for a trigger! */


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)