linux-kernel - Re: [PATCH v2] block: Change to use DEFINE_SHOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEExFWtJEJwgGR3gqfHDXw-c4nyA7dkQTd9fkzVsht=ROmfgMQ@mail.gmail.com>
Date:   Sun, 2 Dec 2018 02:31:59 +0800
From:   Frank Lee <tiny.windzz@...il.com>
To:     axboe@...nel.dk
Cc:     ed.cashin@....org, philipp.reisner@...bit.com,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        Josef Bacik <josef@...icpanda.com>,
        linux-block@...r.kernel.org, josh.h.morris@...ibm.com,
        pjk1939@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
        drbd-dev@...ts.linbit.com, nbd@...er.debian.org
Subject: Re: [PATCH v2] block: Change to use DEFINE_SHOW_ATTRIBUTE macro

On Sun, Dec 2, 2018 at 2:11 AM Jens Axboe <axboe@...nel.dk> wrote:
>
> On 12/1/18 7:24 AM, Yangtao Li wrote:
> > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> > ---
> > changes in v2:
> > -Modify some function names to avoid compilation errors
>
> The fact that your previous patch didn't even compile doesn't fill me
> with a lot of confidence in the amount of diligence and testing
> you apply to your patches.
>
> Why would you send something out that you didn't even compile?
>
> --
> Jens Axboe
>
These changes are the same and only require a small change.
Most of the changes are fine, so it's a bit negligent.

MBR,
Yangtao