linux-kernel - Re: [PATCH net] liquidio: read sc->iq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181130.172058.1554521447549715801.davem@davemloft.net>
Date:   Fri, 30 Nov 2018 17:20:58 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     bianpan2016@....com
Cc:     derek.chickles@...iumnetworks.com,
        satananda.burla@...iumnetworks.com,
        felix.manlunas@...iumnetworks.com,
        raghu.vatsavayi@...iumnetworks.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] liquidio: read sc->iq_no before release sc

From: Pan Bian <bianpan2016@....com>
Date: Thu, 29 Nov 2018 07:54:22 +0800

> The function lio_vf_rep_packet_sent_callback releases the occupation of
> sc via octeon_free_soft_command. sc should not be used after that.
> Unfortunately, sc->iq_no is read. To fix this, the patch stores sc->iq_no
> into a local variable before releasing sc and then uses the local variable
> instead of sc->iq_no.
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Applied.