linux-kernel - Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7468f626-13c0-a53f-bf02-675c7218dd06@gentoo.org>
Date:   Fri, 30 Nov 2018 20:52:25 -0500
From:   Joshua Kinard <kumba@...too.org>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>,
        James Hogan <jhogan@...nel.org>,
        "open list:MIPS" <linux-mips@...ux-mips.org>
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On 11/30/2018 2:27 PM, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> ---
>  arch/mips/pci/ops-bridge.c      | 24 ++++++++++++------------
>  arch/mips/sgi-ip22/ip22-setup.c |  2 +-
>  2 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/mips/pci/ops-bridge.c b/arch/mips/pci/ops-bridge.c
> index a1d2c4ae0d1b..c755c4c92fa9 100644
> --- a/arch/mips/pci/ops-bridge.c
> +++ b/arch/mips/pci/ops-bridge.c
> @@ -56,7 +56,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at it for real ...
>  	 */
>  	if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -76,7 +76,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
>  oh_my_gawd:
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at the wrong register.
>  	 */
>  	if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
> @@ -85,7 +85,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
>  	}
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't try to access
> +	 * IOC3 is hugging hugged beyond belief ...  Don't try to access
>  	 * anything but 32-bit words ...
>  	 */
>  	addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
> @@ -118,7 +118,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at it for real ...
>  	 */
>  	if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -139,7 +139,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
>  oh_my_gawd:
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at the wrong register.
>  	 */
>  	if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
> @@ -148,7 +148,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
>  	}
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't try to access
> +	 * IOC3 is hugging hugged beyond belief ...  Don't try to access
>  	 * anything but 32-bit words ...
>  	 */
>  	bridge->b_pci_cfg = (busno << 16) | (slot << 11);
> @@ -189,7 +189,7 @@ static int pci_conf0_write_config(struct pci_bus *bus, unsigned int devfn,
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at it for real ...
>  	 */
>  	if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -213,14 +213,14 @@ static int pci_conf0_write_config(struct pci_bus *bus, unsigned int devfn,
>  oh_my_gawd:
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to touch the wrong register.
>  	 */
>  	if ((where >= 0x14 && where < 0x40) || (where >= 0x48))
>  		return PCIBIOS_SUCCESSFUL;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't try to access
> +	 * IOC3 is hugging hugged beyond belief ...  Don't try to access
>  	 * anything but 32-bit words ...
>  	 */
>  	addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
> @@ -257,7 +257,7 @@ static int pci_conf1_write_config(struct pci_bus *bus, unsigned int devfn,
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to look at it for real ...
>  	 */
>  	if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -281,14 +281,14 @@ static int pci_conf1_write_config(struct pci_bus *bus, unsigned int devfn,
>  oh_my_gawd:
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't even give the
> +	 * IOC3 is hugging hugged beyond belief ...  Don't even give the
>  	 * generic PCI code a chance to touch the wrong register.
>  	 */
>  	if ((where >= 0x14 && where < 0x40) || (where >= 0x48))
>  		return PCIBIOS_SUCCESSFUL;
>  
>  	/*
> -	 * IOC3 is fucking fucked beyond belief ...  Don't try to access
> +	 * IOC3 is hugging hugged beyond belief ...  Don't try to access
>  	 * anything but 32-bit words ...
>  	 */
>  	addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];

[snip]

NAK'ed to all of the proposed changes to ops-bridge.c.  The SGI IOC3 chip is an
abomination out of some dark, Lovecraftian nightmare, and the code comment is,
truthfully, being somewhat nice in its description of things.  They need to
remain as-is as a warning to future generations of how not to design
multifunction/multidevice chipsets.

-- 
Joshua Kinard
Gentoo/MIPS
kumba@...too.org
rsa6144/5C63F4E3F5C6C943 2015-04-27
177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943

"The past tempts us, the present confuses us, the future frightens us.  And our
lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic