| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <201812021310.fWAbchyX%fengguang.wu@intel.com>
Date: Sun, 2 Dec 2018 13:01:21 +0800
From: kbuild test robot <lkp@...el.com>
To: YueHaibing <yuehaibing@...wei.com>
Cc: kbuild-all@...org, dvhart@...radead.org, andy@...radead.org,
jkosina@...e.cz, linux-kernel@...r.kernel.org,
platform-driver-x86@...r.kernel.org,
andriy.shevchenko@...ux.intel.com,
YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH v2 -next] platform/x86: intel-ips: fix 'passing zero to
PTR_ERR()' warning
Hi YueHaibing,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20181126]
url: https://github.com/0day-ci/linux/commits/YueHaibing/platform-x86-intel-ips-fix-passing-zero-to-PTR_ERR-warning/20181126-213205
config: x86_64-rhel-7.2-clear (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/platform/x86/intel_ips.c: In function 'ips_debugfs_init':
>> drivers/platform/x86/intel_ips.c:1315:3: error: expected ';' before 'return'
return;
^~~~~~
vim +1315 drivers/platform/x86/intel_ips.c
aa7ffc01 Jesse Barnes 2010-05-14 1307
aa7ffc01 Jesse Barnes 2010-05-14 1308 static void ips_debugfs_init(struct ips_driver *ips)
aa7ffc01 Jesse Barnes 2010-05-14 1309 {
aa7ffc01 Jesse Barnes 2010-05-14 1310 int i;
aa7ffc01 Jesse Barnes 2010-05-14 1311
aa7ffc01 Jesse Barnes 2010-05-14 1312 ips->debug_root = debugfs_create_dir("ips", NULL);
aa7ffc01 Jesse Barnes 2010-05-14 1313 if (!ips->debug_root) {
895c026e YueHaibing 2018-11-26 1314 dev_err(ips->dev, "failed to create debugfs entries\n")
aa7ffc01 Jesse Barnes 2010-05-14 @1315 return;
aa7ffc01 Jesse Barnes 2010-05-14 1316 }
aa7ffc01 Jesse Barnes 2010-05-14 1317
aa7ffc01 Jesse Barnes 2010-05-14 1318 for (i = 0; i < ARRAY_SIZE(ips_debug_files); i++) {
aa7ffc01 Jesse Barnes 2010-05-14 1319 struct dentry *ent;
aa7ffc01 Jesse Barnes 2010-05-14 1320 struct ips_debugfs_node *node = &ips_debug_files[i];
aa7ffc01 Jesse Barnes 2010-05-14 1321
aa7ffc01 Jesse Barnes 2010-05-14 1322 node->ips = ips;
aa7ffc01 Jesse Barnes 2010-05-14 1323 ent = debugfs_create_file(node->name, S_IFREG | S_IRUGO,
aa7ffc01 Jesse Barnes 2010-05-14 1324 ips->debug_root, node,
aa7ffc01 Jesse Barnes 2010-05-14 1325 &ips_debugfs_ops);
aa7ffc01 Jesse Barnes 2010-05-14 1326 if (!ent) {
895c026e YueHaibing 2018-11-26 1327 dev_err(ips->dev, "failed to create debug file\n");
aa7ffc01 Jesse Barnes 2010-05-14 1328 goto err_cleanup;
aa7ffc01 Jesse Barnes 2010-05-14 1329 }
aa7ffc01 Jesse Barnes 2010-05-14 1330 }
aa7ffc01 Jesse Barnes 2010-05-14 1331
aa7ffc01 Jesse Barnes 2010-05-14 1332 return;
aa7ffc01 Jesse Barnes 2010-05-14 1333
aa7ffc01 Jesse Barnes 2010-05-14 1334 err_cleanup:
aa7ffc01 Jesse Barnes 2010-05-14 1335 ips_debugfs_cleanup(ips);
aa7ffc01 Jesse Barnes 2010-05-14 1336 return;
aa7ffc01 Jesse Barnes 2010-05-14 1337 }
aa7ffc01 Jesse Barnes 2010-05-14 1338 #endif /* CONFIG_DEBUG_FS */
aa7ffc01 Jesse Barnes 2010-05-14 1339
:::::: The code at line 1315 was first introduced by commit
:::::: aa7ffc01d254c91a36bf854d57a14049c6134c72 x86 platform driver: intelligent power sharing driver
:::::: TO: Jesse Barnes <jbarnes@...tuousgeek.org>
:::::: CC: Matthew Garrett <mjg@...hat.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (41448 bytes)
Powered by blists - more mailing lists