linux-kernel - Re: [PATCH v3] mtd: remove DEBUGFS_RO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEExFWtRoC2dQd_6B5d1c1tt-stdSa4jafBNTsUWJxrZkczfkw@mail.gmail.com>
Date:   Sun, 2 Dec 2018 16:35:20 +0800
From:   Frank Lee <tiny.windzz@...il.com>
To:     boris.brezillon@...tlin.com
Cc:     robert.jarzmik@...e.fr, David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vašut <marek.vasut@...il.com>,
        richard@....at, miquel.raynal@...tlin.com,
        Kees Cook <keescook@...omium.org>,
        Shreeya Patel <shreeya.patel23498@...il.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

On Sun, Dec 2, 2018 at 4:15 PM Boris Brezillon
<boris.brezillon@...tlin.com> wrote:
>
> Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change
> you do. I think you should change the subject line:
>
> "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it"
>
> This way it covers all of your changes.
>
> On Sun,  2 Dec 2018 02:32:02 -0500
> Yangtao Li <tiny.windzz@...il.com> wrote:
>
> > We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define
>
>                                             ^ missing space
>
> > such a macro,so remove DEBUGFS_RO_ATTR.Also use DEFINE_SHOW_ATTRIBUTE
>
>                ^ here as well
>
> > to simplify some code.
>
> If you go for the new subject line, you'll have to change this commit
> message.
How about the newer?

MBR,
Yangtao