linux-kernel - Re: [PATCH] RDMA/uverbs: fix ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181203204705.GE12237@ziepe.ca>
Date:   Mon, 3 Dec 2018 13:47:05 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Doug Ledford <dledford@...hat.com>
Cc:     kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
        Leon Romanovsky <leonro@...lanox.com>,
        Yishai Hadas <yishaih@...lanox.com>,
        Mark Bloch <markb@...lanox.com>,
        Ariel Levkovich <lariel@...lanox.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings

On Mon, Dec 03, 2018 at 12:23:35PM -0500, Doug Ledford wrote:
> On Thu, 2018-11-29 at 16:37 -0700, Jason Gunthorpe wrote:
> > On Wed, Nov 28, 2018 at 07:21:30AM +0800, kbuild test robot wrote:
> > > From: kbuild test robot <fengguang.wu@...el.com>
> > > 
> > > drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> > > 
> > > 
> > >  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> > > 
> > > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> > > 
> > > Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success")
> > > Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> > 
> > applied to for-next, thanks
> > 
> > Jason
> 
> This caused a conflict with your make write() handlers use a consistent
> flow series, which I fixed up during git am run.  Just FYI in case you
> want to check out the conflict spot as a double check (but it was a
> simple fixup).

Looks OK to me thanks

Jason