linux-kernel - Re: [PATCH v1 1/4] dt-bindings: phy-qcom-qmp: Move #clock-cells to child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154387664448.88331.2728522404504674597@swboyd.mtv.corp.google.com>
Date:   Mon, 03 Dec 2018 14:37:24 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Andy Gross <andy.gross@...aro.org>,
        Evan Green <evgreen@...omium.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Douglas Anderson <dianders@...omium.org>,
        Evan Green <evgreen@...omium.org>, devicetree@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/4] dt-bindings: phy-qcom-qmp: Move #clock-cells to child

Quoting Evan Green (2018-11-29 14:13:54)
> The phy-qcom-qmp bindings specified #clock-cells as 1. This was never used
> because of_clk_add_provider() was never called, so there was no way anybody
> could reference these clocks from DT. Furthermore, even if they could be
> accessed, the bindings never specified what should go in that additional
> cell.
> 
> Fix these incomplete and broken bindings. Move the #clock-cells into the
> child node, since that is the actual clock provider, and not all
> instances of qcom-qmp-phy are clock providers. Also set #clock-cells to
> zero, since there's nothing to pass to it.
> 
> Signed-off-by: Evan Green <evgreen@...omium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>