linux-kernel - Re: [v3] mtd: spi-nor: cast to u64 to avoid uint overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181203113459.05f29284@bbrezillon>
Date:   Mon, 3 Dec 2018 11:34:59 +0100
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Huijin Park <huijin.park@...sung.com>,
        Boris Brezillon <boris.brezillon@...tlin.com>
Cc:     linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-mtd@...ts.infradead.org, bbanghj.park@...il.com
Subject: Re: [v3] mtd: spi-nor: cast to u64 to avoid uint overflows

On Mon,  3 Dec 2018 08:51:54 +0100
Boris Brezillon <boris.brezillon@...tlin.com> wrote:

> On Wed, 2018-11-28 at 08:02:14 UTC, Huijin Park wrote:
> > From: "huijin.park" <huijin.park@...sung.com>
> > 
> > The "params->size" is defined as "u64".
> > And "info->sector_size" and "info->n_sectors" are defined as
> > unsigned int and u16.
> > Thus, u64 data might have strange data(loss data) if the result
> > overflows an unsigned int.
> > This patch casts "info->sector_size" to an u64.
> > 
> > Signed-off-by: huijin.park <huijin.park@...sung.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>  
> 
> Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.

Oops, should I been queued to spi-nor/next. I dropped the patch and
will soon push it to spi-nor/next.