linux-kernel - Re: [PATCH v3 3/8] mfd / platform: cros_ec: move vbc attributes to its own driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181203104254.GE26661@dell>
Date:   Mon, 3 Dec 2018 10:42:54 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     gwendal@...omium.org, drinkcat@...omium.org,
        linux-kernel@...r.kernel.org, groeck@...omium.org,
        kernel@...labora.com, bleung@...omium.org,
        Olof Johansson <olof@...om.net>
Subject: Re: [PATCH v3 3/8] mfd / platform: cros_ec: move vbc attributes to
 its own driver.

On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:

> The entire way how cros sysfs attibutes are created is broken.
> cros_ec_vbc should be its own driver and its attributes should be
> associated with a vbc driver not the mfd driver. In order to retain
> the path, the vbc attributes are attached to the cros_class.
> 
> The patch also adds the sysfs documentation.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
> 
> Changes in v3:
> - Fixed build error as reported by the kbuild test robot.
> 
> Changes in v2:
> - Removed unneeded check of ec_dev.
> 
>  .../sysfs-class-chromeos-driver-cros-ec-vbc   |  6 +++
>  drivers/mfd/cros_ec_dev.c                     |  2 +-
>  drivers/platform/chrome/Kconfig               | 10 +++++
>  drivers/platform/chrome/Makefile              |  3 +-
>  drivers/platform/chrome/cros_ec_vbc.c         | 43 ++++++++++++++++++-
>  include/linux/mfd/cros_ec.h                   |  1 -
>  6 files changed, 61 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-class-chromeos-driver-cros-ec-vbc

Patch looks fine, so long as drivers/platform is the right place for
this driver to reside.  No better subsystems for it?

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog