linux-kernel - Re: [PATCH] tools: Fix diverse typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Dec 2018 11:52:19 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Arnaldo Carvalho de Melo <acme@...radead.org>,
        linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...hat.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] tools: Fix diverse typos


* Peter Zijlstra <peterz@...radead.org> wrote:

> On Mon, Dec 03, 2018 at 11:22:00AM +0100, Ingo Molnar wrote:
> > Go over the tools/ files that are maintained in Arnaldo's tree and
> > fix common typos: half of them were in comments, the other half
> > in JSON files.
> > 
> > ( Care should be taken not to re-import these typos in the future,
> >   if the JSON files get updated by the vendor without fixing the typos. )
> 
> >  .../perf/pmu-events/arch/x86/broadwell/cache.json  |  4 +--
> >  .../pmu-events/arch/x86/broadwell/pipeline.json    |  2 +-
> >  .../pmu-events/arch/x86/broadwellde/cache.json     |  4 +--
> >  .../pmu-events/arch/x86/broadwellde/pipeline.json  |  2 +-
> >  .../perf/pmu-events/arch/x86/broadwellx/cache.json |  4 +--
> >  .../pmu-events/arch/x86/broadwellx/pipeline.json   |  2 +-
> >  tools/perf/pmu-events/arch/x86/jaketown/cache.json |  4 +--
> >  .../pmu-events/arch/x86/jaketown/pipeline.json     |  2 +-
> >  .../pmu-events/arch/x86/knightslanding/cache.json  | 30 +++++++++++-----------
> >  .../pmu-events/arch/x86/sandybridge/cache.json     |  4 +--
> >  .../pmu-events/arch/x86/sandybridge/pipeline.json  |  2 +-
> >  .../pmu-events/arch/x86/skylakex/uncore-other.json | 12 ++++-----
> 
> Yeah, so I think those are generated from somewhere, fixing them here
> isn't going to nessecarily help much.

It's in our source code, the output is visible to our users, so such 
typos should be fixed.

But yes, I agree that the fixes should also be applied at the Intel 
source of the JSON definitions.

Thanks,

	Ingo