linux-kernel - Re: [PATCH v5 02/21] lib/vsprintf: Print time and date in human readable format via %pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUXQX=Y6K5XZok38W75KSBM+5PNRMKMhavNG_JtbxoNAw@mail.gmail.com>
Date:   Tue, 4 Dec 2018 17:16:58 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Joe Perches <joe@...ches.com>,
        Mark Salyzyn <salyzyn@...roid.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        Greg KH <gregkh@...uxfoundation.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Guan Xuetao <gxt@...c.pku.edu.cn>,
        Ingo Molnar <mingo@...nel.org>,
        Jason Wessel <jason.wessel@...driver.com>,
        Jonathan Corbet <corbet@....net>,
        Jon Hunter <jonathanh@...dia.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH v5 02/21] lib/vsprintf: Print time and date in human
 readable format via %pt

Hi Andy,

On Tue, Dec 4, 2018 at 5:12 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Tue, Dec 04, 2018 at 02:30:28PM +0100, Petr Mladek wrote:
> > On Thu 2018-11-29 12:59:40, Andy Shevchenko wrote:
> > > There are users which print time and date represented by content of
> > > struct rtc_time in human readable format.
> > >
> > > Instead of open coding that each time introduce %ptR[dt][r] specifier.
>
> > > +static void __init
> > > +struct_rtc_time(void)
> > > +{
> > > +}
> >
> > Just by chance, do you have any plans to add the test code? ;-)
> >
> > I understand that you did now want to spend time on it before
> > the real change was accepted.
>
> You see, there were several iterations with no consensus on everything:
> specifier format changed 3 times, for example.
>
> But it might be good idea to eventually add couple simple tests at some point.
>
> Is it a show stopper?

Can the user trigger formatting, and exploit a bug in the formatting code?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds