linux-kernel - Re: [PATCH] i3c: Rename dw-i3c-master.c into i3c-master-dw.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07f663b9-a973-39cf-c1ab-cc5ffb1a6210@synopsys.com>
Date:   Tue, 4 Dec 2018 18:28:12 +0000
From:   vitor <vitor.soares@...opsys.com>
To:     Boris Brezillon <boris.brezillon@...tlin.com>,
        vitor <vitor.soares@...opsys.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i3c: Rename dw-i3c-master.c into i3c-master-dw.c

Hi Boris,

On 04/12/18 00:38, vitor wrote:
> Hi Boris,
>
>
> On 03/12/18 10:07, Boris Brezillon wrote:
>> Hi Vitor,
>>
>> On Mon, 26 Nov 2018 09:45:14 +0100
>> Boris Brezillon <boris.brezillon@...tlin.com> wrote:
>>
>>> Follow the naming scheme introduced by the Cadence driver to keep 
>>> things
>>> consistent.
>>>
>>> Signed-off-by: Boris Brezillon <boris.brezillon@...tlin.com>
>>> ---
>>>   drivers/i3c/master/Makefile                             | 2 +-
>>>   drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} | 0
>>>   2 files changed, 1 insertion(+), 1 deletion(-)
>>>   rename drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} (100%)
>> Any opinion on this rename. If you disagree with this, then I'd like to
>> know it.
>>
>> Regards,
>>
>> Boris


I don't agree with the master folder name. The name is redundant.


If you want to change my driver name I don't mind.


>>
>>> diff --git a/drivers/i3c/master/Makefile b/drivers/i3c/master/Makefile
>>> index fc53939a0bb1..c5f52733aa10 100644
>>> --- a/drivers/i3c/master/Makefile
>>> +++ b/drivers/i3c/master/Makefile
>>> @@ -1,2 +1,2 @@
>>>   obj-$(CONFIG_CDNS_I3C_MASTER)        += i3c-master-cdns.o
>>> -obj-$(CONFIG_DW_I3C_MASTER)        += dw-i3c-master.o
>>> +obj-$(CONFIG_DW_I3C_MASTER)        += i3c-master-dw.o
>>> diff --git a/drivers/i3c/master/dw-i3c-master.c 
>>> b/drivers/i3c/master/i3c-master-dw.c
>>> similarity index 100%
>>> rename from drivers/i3c/master/dw-i3c-master.c
>>> rename to drivers/i3c/master/i3c-master-dw.c
>
>
> I already reply on initial thread. Please check my answers.
>
>
> Best regards,
>
> Vitor Soares


Best regards,

Vitor Soares