[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5C06D686.50108@baylibre.com>
Date: Tue, 04 Dec 2018 20:33:26 +0100
From: Neil Armstrong <narmstrong@...libre.com>
To: Stephen Boyd <sboyd@...nel.org>, jbrunet@...libre.com
CC: linux-clk@...r.kernel.org, linux-amlogic@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: meson-gxbb: switch video clocks mux tables to static
Hi Stephen,
Le 04/12/2018 18:43, Stephen Boyd a écrit :
> Quoting Neil Armstrong (2018-12-04 04:58:39)
>> Makes the following sparse warnings silent:
>> drivers/clk/meson/vid-pll-div.c:58:26: warning: symbol '_get_table_val' was not declared. Should it be static?
>> drivers/clk/meson/gxbb.c:1585:12: warning: symbol 'gxbb_vid_pll_parent_names' was not declared. Should it be static?
>> drivers/clk/meson/gxbb.c:1620:12: warning: symbol 'gxbb_vclk_parent_names' was not declared. Should it be static?
>> drivers/clk/meson/gxbb.c:1980:12: warning: symbol 'gxbb_cts_parent_names' was not declared. Should it be static?
>> drivers/clk/meson/gxbb.c:2036:12: warning: symbol 'gxbb_cts_hdmi_tx_parent_names' was not declared. Should it be static?
>
> I fixed all of these already in the patch I sent you.
Sorry I misunderstood...
>
>> @@ -1983,7 +1983,7 @@ static struct clk_fixed_factor gxbb_vclk2_div12 = {
>> };
>>
>> static u32 mux_table_cts_sel[] = { 0, 1, 2, 3, 4, 8, 9, 10, 11, 12 };
>
> I was talking about this mux_table_cts_sel array. Can this be const?
>
Other mux tables aren't const, Jerome so you see a reason why they aren't const ?
Neil
Powered by blists - more mailing lists