linux-kernel - Re: [PATCH] drm/msm: Only add available components

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGt2Chk5kjFXyHg4CaxcOzUPZCMz0UzT4se43oYnt5SxJw@mail.gmail.com>
Date:   Tue, 4 Dec 2018 15:19:51 -0500
From:   Rob Clark <robdclark@...il.com>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Sean Paul <seanpaul@...omium.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Jordan Crouse <jcrouse@...eaurora.org>,
        Jeykumar Sankaran <jsanka@...eaurora.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        freedreno <freedreno@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/msm: Only add available components

On Tue, Dec 4, 2018 at 1:04 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> When trying to get the display up on my sdm845 board I noticed that
> the display wouldn't probe if I had the dsi1 node marked as "disabled"
> even though my board doesn't use dsi1.  It looks like the msm code
> adds all nodes to its list of components even if they are disabled.  I
> believe this doesn't work because all registered components need to
> come up before we finish probing.  Let's do like other DRM code and
> only add available components.
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>


yeah, that seems like a reasonable thing to do

Reviewed-by: Rob Clark <robdclark@...il.com>

> ---
>
>  drivers/gpu/drm/msm/msm_drv.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index b1577e960889..0b828822117b 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -1190,8 +1190,10 @@ static int add_components_mdp(struct device *mdp_dev,
>                 if (!intf)
>                         continue;
>
> -               drm_of_component_match_add(master_dev, matchptr, compare_of,
> -                                          intf);
> +               if (of_device_is_available(intf))
> +                       drm_of_component_match_add(master_dev, matchptr,
> +                                                  compare_of, intf);
> +
>                 of_node_put(intf);
>         }
>
> --
> 2.20.0.rc1.387.gf8505762e3-goog
>