linux-kernel - [PATCH v2 BlueZ] hid2hci: Fix udev rules for linux-4.14+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181204204117.14964-1-ville.syrjala@linux.intel.com>
Date:   Tue,  4 Dec 2018 22:41:17 +0200
From:   Ville Syrjala <ville.syrjala@...ux.intel.com>
To:     linux-bluetooth@...r.kernel.org
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Kay Sievers <kay.sievers@...y.org>,
        Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>,
        systemd-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2 BlueZ] hid2hci: Fix udev rules for linux-4.14+

From: Ville Syrjälä <ville.syrjala@...ux.intel.com>

Since commit 1455cf8dbfd0 ("driver core: emit uevents when
device is bound to a driver") the kernel started emitting
"bind" and "unbind" uevents which confuse the hid2hci
udev rules.

The symptoms on an affected machine (Dell E5400 in my case)
include bluetooth devices not appearing and udev hogging
the cpu as it's busy processing a constant stream of these
"bind"+"unbind" uevents.

Change the udev rules not do anything except for "add" and
"change" events. This seems to cure my machine at least.

v2: Don't mess up "change" (Zbyszek)
    Fix up the commit message a bit

Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Marcel Holtmann <marcel@...tmann.org>
Cc: Kay Sievers <kay.sievers@...y.org>
Cc: Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>
Cc: systemd-devel@...ts.freedesktop.org
Cc: linux-kernel@...r.kernel.org
Cc: linux-bluetooth@...r.kernel.org
---
Reposting with BlueZ in subject and sob stripped. Maybe that helps in
getting a oneliner merged?

 tools/hid2hci.rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hid2hci.rules b/tools/hid2hci.rules
index db6bb03d2ef3..5c7208af7a02 100644
--- a/tools/hid2hci.rules
+++ b/tools/hid2hci.rules
@@ -1,6 +1,6 @@
 # do not edit this file, it will be overwritten on update
 
-ACTION=="remove", GOTO="hid2hci_end"
+ACTION!="add|change", GOTO="hid2hci_end"
 SUBSYSTEM!="usb*", GOTO="hid2hci_end"
 
 # Variety of Dell Bluetooth devices - match on a mouse device that is
-- 
2.16.4