linux-kernel - Re: [PATCH v2 19/24] locking/lockdep: Check data structure consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb34f533-cd83-0ec8-5f09-15d80950674f@redhat.com>
Date:   Tue, 4 Dec 2018 15:53:43 -0500
From:   Waiman Long <longman@...hat.com>
To:     Bart Van Assche <bvanassche@....org>, mingo@...hat.com
Cc:     peterz@...radead.org, tj@...nel.org, johannes.berg@...el.com,
        linux-kernel@...r.kernel.org,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH v2 19/24] locking/lockdep: Check data structure
 consistency

On 12/03/2018 07:28 PM, Bart Van Assche wrote:
> Debugging lockdep data structure inconsistencies is challenging. Add
> disabled code that verifies data structure consistency at runtime.
>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Waiman Long <longman@...hat.com>
> Cc: Johannes Berg <johannes@...solutions.net>
> Signed-off-by: Bart Van Assche <bvanassche@....org>
> ---
>  kernel/locking/lockdep.c | 147 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 147 insertions(+)

lockdep.c has close to 5000 lines of code. I wonder if we should move
most of the relocatable lockdep debugging code into a separate
lockdep_debug.c file to make it easier to manage the core lockdep code.
That, of course, will include most of the code from this patch.

Cheers,
Longman